Another minor bug in Unity SDK

[VRandArchI]

I've found another typo in Unity version of SRanipal SDK, version 1.0.1.0.
File: ViveSR\Scripts\SRanipal_Eye.cs, line 162
Function:

SRanipal_Eye.GetEyeOpenness(EyeIndex eye, out float openness)

Description: Function always returns true, despite code comments saying that it should return data validity.
Solution: Change line

return true;

to

return valid

PS: While UE version of SDK doesn't have this error, it also doesn't check whether framework is active, while Unity current version does. This is also probably not intended behaviour.

[Corvus]

Thanks for catching this! We'll get this fixed in an update.

[mrk88]

and maybe

 

bool valid = true;

at the beginning of function ?

otherwise it didn't recognize valid

 

 

 

[VRandArchI]

---

 wrote:

and maybe

 

bool valid = true;

at the beginning of function ?

otherwise it didn't recognize

valid

 

 

 

---

Yeah, good point.